[Webkit-unassigned] [Bug 80126] [EFL] Add API to set platform dependent editing behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80126





--- Comment #5 from Sudarsana Nagineni <naginenis at gmail.com>  2012-03-14 07:19:25 PST ---
(In reply to comment #4)

Thanks for review!

>  * You seem to be making 3 separate changes in a single patch (adding tests to the skipped list, adding the backspace stuff and implementing ewk_view_setting_editing_behavior_set). Please split these up into separate patches.

I will split this into separate patches.

>  * Please also add a getter for the ewk_view function you have added, and properly document what the default is.

Ok.

> > LayoutTests/platform/efl/Skipped:211
> > +editing/selection/extend-selection-after-double-click.html
> > +editing/selection/rtl-move-selection-right-left.html
> > +editing/selection/shift-click.html
> 
> Are these tests related to this commit? If they aren't, I'd rather commit these entries separately (and they should be sorted alphabetically with the rest of the block).
> 
> > LayoutTests/platform/efl/Skipped:233
> > +editing/selection/5354455-1.html
> > +editing/selection/context-menu-text-selection.html
> > +editing/selection/extend-after-mouse-selection.html
> 

These tests are already there in the skip list, but the description was wrong. So, I moved them to correct place. 

> > Source/WebKit/efl/ewk/ewk_view.cpp:3919
> > +Eina_Bool ewk_view_setting_editing_behavior_set(Evas_Object* ewkView, Ewk_Editing_Behavior behavior)
> 
> In general, our setters do not return anything; I think we can do the same here.

Ok, I will change this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.