[Webkit-unassigned] [Bug 80981] [GTK] [WK2] Add dom paste setting to WebKit2 GTK+ API

Tue Mar 13 23:00:47 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=80981

--- Comment #5 from Antaryami Pandia <antaryami.pandia at motorola.com>  2012-03-13 23:00:47 PST ---
Thanks for the feedback.

> What's missing here is some context as to why this is disabled by default and why one would want to enable it.

The "m_isDOMPasteAllowed" settings (webcore settings which is set by this websttings -enable-dom-paste) is initialized false. Also in webkit1 this is disabled by default.

> Patch looks good to me in general, but I'm a bit confusing about what dom paste is reading the gtk-doc comments.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:851
> > +     * WebKitSettings:enable-dom-paste
> 
> Trailing : missing here.

Will do.

> What is dom paste? Does this mean if this setting is disabled "Paste" editing command doesn't work? 

the enable-dom-paste is used to set the "m_isDOMPasteAllowed". Webcore use this flag to see if dome paste is enabled or not while executing document.execCommand("Paste"). Method supportedPaste() in EditorCommand.cpp. 

> What does "correctly" means in this case? why this setting guarantees the command is executed correctly.

I have used the comment used in webkit1 webkitwebsettings. The main purpose of the flag is to enable dom paste. Please let me know if I should change the comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.