[Webkit-unassigned] [Bug 81061] Functions with C linkage should not return C++ classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81061


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131758|review?                     |review+
               Flag|                            |




--- Comment #5 from Mark Rowe (bdash) <mrowe at apple.com>  2012-03-13 17:32:52 PST ---
(From update of attachment 131758)
View in context: https://bugs.webkit.org/attachment.cgi?id=131758&action=review

Looks fine to me.

> Source/JavaScriptCore/ChangeLog:3
> +        Need a short description and bug URL (OOPS!)

Describe the problem!

> Source/JavaScriptCore/dfg/DFGOperations.h:160
> +// According to C++ rules, a type used for the return signature of function with C linkage (i.e.
> +// 'extern "C"') needs to be POD in the C++-03 sense: loosely speaking it must have nothing more than
> +// those members that would be valid in C. This means no constructors.

I don't think it's necessary to explain what a POD type is here. I'd simplify this to something like:
// Since this type is used in the signature of a function declared with C linkage it must be a POD type.

> Source/JavaScriptCore/llint/LLIntSlowPaths.h:44
> +// According to C++ rules, a type used for the return signature of function with C linkage (i.e.
> +// 'extern "C"') needs to be POD in the C++-03 sense: loosely speaking it must have nothing more than
> +// those members that would be valid in C. This means no constructors.

Same comment about the comment here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.