[Webkit-unassigned] [Bug 81059] Rebaseline server can't deal with platform-specific tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81059





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2012-03-13 17:30:07 PST ---
to clarify: "rebaseline server" == 'webkit-patch rebaseline-server"? I don't actually know how well supported that tool is at the moment, so consider yourself warned.

Apart from that, I am not surprised by this - we put new baselines in the platform-specific directory by default, so putting the baseline for a platform-specific test in the platform-specific directory for that test is consistent.

Which is not necessarily saying that it's right :).

For comparison, with old-run-webkit-tests, for platform-independent tests, I believe new baselines would be written into platform/mac by default, platform/mac-lion (or whatever version as appropriate) with --add-platform-exceptions, and into the generic directory with --reset-results. I don't know what it did with platform-specific tests.

I believe new-run-webkit-tests uses --new-baseline instead of --add-platform-exceptions. I would expect it to treat platform-specific tests the same as platform-independent tests.

I could be wrong about both of these (haven't tested the behavior).

Ideally 'webkit-patch rebaseline-server' and 'new-run-webkit-tests' would have the same behavior and use the same set of command line flags to change behavior.

If there is agreement on how we want it to work, I'll be happy to implement whatever. Can someone please propose a full strawman for this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.