[Webkit-unassigned] [Bug 80713] Add new methods to FrameLoaderClient so different WebKit ports can customize the ResourceRequest when it is created.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 15:31:19 PDT 2012


--- Comment #47 from jochen at chromium.org  2012-03-13 15:31:18 PST ---
(In reply to comment #46)
> (In reply to comment #45)
> > 
> > No, I want to get rid of the ifdefs
> > 
> > target type should not be part of resource request
> > 
> > Instead, all loader related methods that take a resource request should also take a target type parameter, e.g. ThreadableLoader::create should take ScriptExecutionContext, ThreadableLoaderClient, ResourceRequest, TargetType, and ThreadableLoaderOptions parameters.
> > 
> > TargetType could either be owned by FrameLoader or some other class in loader/
> > 
> Like your patch for https://bugs.webkit.org/show_bug.cgi?id=65855? It is unfortunately there for about 5 months now without a r+ or r-.

I take comment 23 on that bug as a r-

However, the approach I took in that patch was also different from what I described above. It introduces a new class that binds a ResourceRequest and a TargetType together. What I think might be a solution (and I tried to describe above) is not introducing a new class, but just plumbing the two values everywhere we need them.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list