[Webkit-unassigned] [Bug 78856] visual word movement: Using ICU break iterator to simplify implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78856





--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-13 14:16:32 PST ---
(From update of attachment 131476)
View in context: https://bugs.webkit.org/attachment.cgi?id=131476&action=review

> LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:5
> +"begin start"[0, 6], "abc def"[0, 4], "end ing"[0, 4], "this is float"[0, 5, 8], "this is fixed"[0, 5, 8], "this is relative"[0, 5, 8], "this is absolute"[0, 5, 8, 16]

It's great see a bug being fixed :D

> LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element.html:21
> +title="[d_1, 0][d_1, 6][d_2, 0][d_2, 4][d_3, 0][d_3, 4][d_4, 0][d_4, 5][d_4, 8][d_5, 0][d_5, 5][d_5, 8][d_6, 0][d_6, 5][d_6, 8][d_7, 0][d_7, 5][d_7, 8][d_7, 16]|
> +[d_7, 16][d_7, 8][d_7, 5][d_7, 0][d_6, 8][d_6, 5][d_6, 0][d_5, 8][d_5, 5][d_5, 0][d_4, 8][d_4, 5][d_4, 0][d_3, 4][d_3, 0][d_2, 4][d_2, 0][d_1, 6][d_1, 0]" 

Maybe we want to change the format to make it more semantically clear. Of course, in a separate patch :)
It's really hard to understand what's going on here.

> LayoutTests/editing/selection/move-by-word-visually-multi-line-expected.txt:40
> +"abc def ghi jkl mn "[0, 3, 8, 11, 16], "opq rst uvw xyz"[0, 3, 8, 11, 15]

It's great to see this test case passing but can we print PASS in these passing cases? (in a separate patch, of course).

> LayoutTests/editing/selection/move-by-word-visually-multi-line.html:57
> +<div contenteditable dir=rtl id="ml_8" class="test_move_by_word fix_width" title="[ml_8, 15, 5][ml_8, 11, 5][ml_8, 8, 5][ml_8, 3, 5][ml_8, 0, 5][ml_8, 16][ml_8, 11][ml_8, 8][ml_8, 3][ml_8, 0]|[ml_8, 0][ml_8, 3][ml_8, 8][ml_8, 11][ml_8, 16][ml_8, 0, 5][ml_8, 3, 5][ml_8, 8, 5][ml_8, 11, 5][ml_8, 15, 5]">abc def ghi jkl mn <div><br/></div><div><br/></div><div><br/></div>opq rst uvw xyz</div>

Please explain the change in the change log as done in person :)
I understand that this is an improvement after talking with you, but it'll be nice to document it here so that other contributors like ap and mitz can understand it as well without having to talk with you in person.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.