[Webkit-unassigned] [Bug 72841] NRWT: option --skip-pixel-test-if-no-baseline support on DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 12:27:21 PDT 2012


--- Comment #12 from Dirk Pranke <dpranke at chromium.org>  2012-03-13 12:27:20 PST ---
(From update of attachment 131598)
This looks pretty close to what I had in mind. If you make the changes I suggest below, that might fix your problems; if not, I'll probably have to take another look at it to figure out what's going on.


View in context: https://bugs.webkit.org/attachment.cgi?id=131598&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:114
> +        # because it still does pixeltests in this case

this logic should be inside self._driver_input().

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:126
> +            if self._port.get_option('skip_pixel_test_if_no_baseline') and self._port.get_option('pixel_tests'):

I think the logic in this branch looks shady, but that's probably because we have the self._pixel_tests logic in other places as well. We should consolidate it all here, probably to something like:

if self._port.get_option('pixel_tests'):
    if self._port.get_option('skip_pixel_test_if_no_baseline'):
        test_input.should_run_pixel_test = (self._port.expected_image(test_input.test_name) != None)
        test_input.should_run_pixel_test = True
    test_input.should_run_pixel_test = False

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:211
> +        pixel_tests_needed = self._pixel_tests or driver_input.run_pixel_test

I think you can get rid of the self._pixel_tests member completely and just use driver_input.run_pixel_test here.

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:559
> +            self._start(driver_input.run_pixel_test or self._pixel_tests, [])

See comment above and see if we can remove self._pixel_tests here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list