[Webkit-unassigned] [Bug 80126] [EFL] Add API to set platform dependent editing behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80126





--- Comment #4 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-03-13 07:32:48 PST ---
(From update of attachment 131601)
View in context: https://bugs.webkit.org/attachment.cgi?id=131601&action=review

Thanks for the patch. A few more general comments besides those I made inline:
 * You seem to be making 3 separate changes in a single patch (adding tests to the skipped list, adding the backspace stuff and implementing ewk_view_setting_editing_behavior_set). Please split these up into separate patches.
 * Please also add a getter for the ewk_view function you have added, and properly document what the default is.

> LayoutTests/platform/efl/Skipped:211
> +editing/selection/extend-selection-after-double-click.html
> +editing/selection/rtl-move-selection-right-left.html
> +editing/selection/shift-click.html

Are these tests related to this commit? If they aren't, I'd rather commit these entries separately (and they should be sorted alphabetically with the rest of the block).

> LayoutTests/platform/efl/Skipped:233
> +editing/selection/5354455-1.html
> +editing/selection/context-menu-text-selection.html
> +editing/selection/extend-after-mouse-selection.html

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:3919
> +Eina_Bool ewk_view_setting_editing_behavior_set(Evas_Object* ewkView, Ewk_Editing_Behavior behavior)

In general, our setters do not return anything; I think we can do the same here.

> Source/WebKit/efl/ewk/ewk_view.h:2371
> +    EWK_EDITING_BEHAVIOR_MAC,
> +    EWK_EDITING_BEHAVIOR_WIN,
> +    EWK_EDITING_BEHAVIOR_UNIX

Please document what each of these values is supposed to mean (ie. how they are different from each other).

> Source/WebKit/efl/ewk/ewk_view.h:2377
> + * Sets the editing behavior of editable elements.

Please briefly explain what editing behavior means, and what the default is.

> Source/WebKit/efl/ewk/ewk_view.h:2384
> +EAPI Eina_Bool ewk_view_setting_editing_behavior_set(Evas_Object* o, Ewk_Editing_Behavior behavior);

This is slightly odd, but the asterisk should be next to "o" here, as we follow EFL's coding style in public headers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.