[Webkit-unassigned] [Bug 80800] [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 23:26:28 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80800





--- Comment #5 from Jason <jason.liu at torchmobile.com.cn>  2012-03-12 23:26:25 PST ---
>> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:183
>> +                if (key.contains("Cookie"))

>instead of checking for key.contains("Cookie"), which you may want to verify >if it's case sensitive or not, you could use >String::fromUTF8WithLatin1Fallback similarly to how it's called in >FrameLoaderClienBlackBerry::dispatchWillSendRequest().  This could be more >efficient than a string comparison.

Joe Mason suggests to talk about checking all headers in another PR.
So I make an if() branch to ensure only check cookies.

And I don't know how to use String::fromUTF8WithLatin1Fallback instead of if(key.contains("Cookies").

Can you give me some detail information?

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list