[Webkit-unassigned] [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27160





--- Comment #69 from Joe Thomas <joethomas at motorola.com>  2012-03-12 15:15:29 PST ---
(In reply to comment #68)
> Looking at this patch, I think what we really want to do is to move calc*Value functions out from Length (and platform). That will remove the need to have clumsy virtual interface just to avoid the layering violation.
> 
> So instead of something like
> 
> return offset + style()->top().calcValue(containingBlock->availableHeight(), view());
> 
> you would have
> 
> return offset + calculateValue(style()->top(), containingBlock->availableHeight(), view());
> 
> where calculateValue() is defined in WebCore/css/LengthFunctions.h/.cpp (or similar).
> 
> It would be good to do this refactoring first, separate from the viewport size feature. How does this sound?

I think it is a good idea. Bug 80897 is created for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.