[Webkit-unassigned] [Bug 80191] Convert some fast/regions pixel tests to reftests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80191


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130402|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Dirk Schulze <krit at webkit.org>  2012-03-12 15:03:19 PST ---
(From update of attachment 130402)
View in context: https://bugs.webkit.org/attachment.cgi?id=130402&action=review

> LayoutTests/ChangeLog:6
> +        Convert some fast/regions pixel tests to reftests
> +        https://bugs.webkit.org/show_bug.cgi?id=80191
> +
> +        Reviewed by NOBODY (OOPS!).

Your change log should be more explicit what you try to do with your patch, why you do it and how you do it. Also, you modified the test itself without a comment why you did it. Is the test still testing the same?

> LayoutTests/fast/regions/bottom-overflow-out-of-first-region.html:-6
> -        text-align: justify;

Why did you remove this line?

> LayoutTests/fast/regions/bottom-overflow-out-of-first-region.html:-61
> -    <div id="region3"></div>

It is not desirable to modify the test to match the reference. It should be the other way around. Why did you remove the region here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.