[Webkit-unassigned] [Bug 80880] New: [V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 13:48:15 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80880

           Summary: [V8] Use v8::V8::AddHiddenReferences instead of
                    SetHiddenValue
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: arv at chromium.org
                CC: abarth at webkit.org, japhet at chromium.org,
                    antonm at chromium.org, haraken at chromium.org


Created an attachment (id=131400)
 --> (https://bugs.webkit.org/attachment.cgi?id=131400&action=review)
Per test

This is part of the patch from bug 78149 but without the collection part. I'm doing this in two parts since using v8::V8::AddHiddenReferences is an improvement over SetHiddenValue by itself.

In the attached perf test creating a classList is 3.4 times faster.

With patch

1.46ns/classList
1.41ns/classList
1.47ns/classList
1.41ns/classList

Without patch

4.890000000000001ns/classList
4.8999999999999995ns/classList
4.83ns/classList
4.9399999999999995ns/classList

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list