[Webkit-unassigned] [Bug 80615] CopiedSpace::tryAllocateOversize assumes system page size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80615


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131073|review?                     |review-
               Flag|                            |




--- Comment #5 from Geoffrey Garen <ggaren at apple.com>  2012-03-12 12:18:47 PST ---
(From update of attachment 131073)
View in context: https://bugs.webkit.org/attachment.cgi?id=131073&action=review

r- based on Mark's comments.

> Source/JavaScriptCore/heap/CopiedSpaceInlineMethods.h:174
> +    size_t pageMask = ~(WTF::pageSize() - 1);

I'd prefer to see a WTF::pageMask() function, rather than one-off code in lots of places.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.