[Webkit-unassigned] [Bug 76816] Implement the URL decomposition IDL attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76816





--- Comment #40 from Erik Arvidsson <arv at chromium.org>  2012-03-12 11:56:40 PST ---
(From update of attachment 131316)
In general GURL is correct and KURL is wrong. You are probably better of building and testing this with --chromium and checking in different test expectations for KURL based platforms.

View in context: https://bugs.webkit.org/attachment.cgi?id=131316&action=review

> LayoutTests/fast/dom/DOMURL/domurl-attribute-hash.html:52
> +domurl.hash = null;
> +shouldBeEqualToString("domurl.href", "https://www.mydomain.com/testurl.html#");

This doesn't match Location

window.location.hash = null
null
window.location.hash
"#null"

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:70
> +domurl.host = "www.other\dom/ain.com";

What is '\d'? '\d' has no special meaning in JS so it is treated as 'd'. If you want some escape sequence use something of the form \u1234. Maybe you just wanted a backslash? Then use '\\'

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:71
> +shouldBeEqualToString("domurl.href", "https://www.otherdom/ain.com/path/");

This is wrong. It should be

'https://www.otherdom%2Fain.com/path/'

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:74
> +domurl.href = "https:/\rww.my at domain.com:8080/path/";

Did you really mean \r as in carriage return?

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:76
> +shouldBeEqualToString("domurl.href", "https:/\rww.my at domain.com:8080/path/");

This is wrong. It should be

'https://ww.my@www.other%21domain.com:15/path/'

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:85
> +domurl.host = "www.other!domain.com:25";

'!' is not allowed in the domain name

> LayoutTests/fast/dom/DOMURL/domurl-attribute-host.html:86
> +shouldBeEqualToString("domurl.href", "https://rwwmy@www.other!domain.com:25/pa..th/");

The expected URL here is

'https://rwwmy@www.other%21domain.com:25/pa..th/'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.