[Webkit-unassigned] [Bug 77712] [JSC] Range of cache flush is not guaranteed by Linux kernel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77712


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131268|review?                     |review-
               Flag|                            |




--- Comment #11 from Geoffrey Garen <ggaren at apple.com>  2012-03-12 11:45:54 PST ---
(From update of attachment 131268)
View in context: https://bugs.webkit.org/attachment.cgi?id=131268&action=review

> Source/JavaScriptCore/jit/ExecutableAllocator.h:209
> +            current = next;

You can eliminate the "next" variable if you change this line to "current += pageSize()".

> Source/JavaScriptCore/jit/ExecutableAllocator.h:211
> +        } while (end >= current);

In C++, "end" traditionally means one-past-the-end. That's not the case here, so I don't think you should use the word "end".

I'd suggest "currentPage" and "lastPage" for variable names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.