[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75824


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tony at chromium.org




--- Comment #12 from Tony Chang <tony at chromium.org>  2012-03-12 10:51:48 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Interesting.  Does this mean that this check will never catch anything for patches put up here by git users? (As long as the style checker machine is set-up correctly and runs git.)
> 
> As far as I know svn:mime-type settings aren't in the patches. But you have 
> to setup your svn config correctly on the machine where you commit from.
> 
> If you run check-webkit-style before committing it will warn you if your 
> svn config is incorrect.

Right, this is what I was saying in comment #3.  For git users, this is the best you can do.  For svn users, it would be better to actually check the properties of png files (although checking the config file doesn't hurt either).

I thought this bug was for the svn user case, but this seems like a reasonable first step.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.