[Webkit-unassigned] [Bug 80800] [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80800





--- Comment #3 from Konrad Piascik <kpiascik at rim.com>  2012-03-12 06:40:40 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=131300&action=review

> Source/WebCore/ChangeLog:3
> +        [BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.

Can you clarify what the regression is in the commit message and how it is fixed.  I know its in the bug but it should also be in the commit message.

> Source/WebCore/ChangeLog:8
> +        No new tests.

There should be a UTF8 vs latin1 test you can add to test your fix.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:183
> +                if (key.contains("Cookie"))

instead of checking for key.contains("Cookie"), which you may want to verify if it's case sensitive or not, you could use String::fromUTF8WithLatin1Fallback similarly to how it's called in FrameLoaderClienBlackBerry::dispatchWillSendRequest().  This could be more efficient than a string comparison.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:192
> +        if (cookiesEnabled && (isRedirect || !httpHeaderField("Cookie").length())) {

Can you elaborate on why this could happen?

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:212
> +    request.initializePlatformRequest(platformRequest, cookiesEnabled(), false /*isInitial*/);

false /*isInitial*/
This doesn't need to be here since false is the default value.  Either it should be taken out for all the calls to initializePlatformRequest, or you should also add "false /*isRedirect*/" to each method call in FrameLoaderClientBlackBerry for consistency.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:941
> +    request.initializePlatformRequest(platformRequest, cookiesEnabled(), 0, false /*isInitial*/);

is this a typo?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.