[Webkit-unassigned] [Bug 20040] Vertical border spacing is doubled between table row groups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 06:37:59 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=20040





--- Comment #33 from Kishore Bolisetty <kbolisetty at innominds.com>  2012-03-12 06:37:58 PST ---
(In reply to comment #32)
> Attachment 131319 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
> Traceback (most recent call last):
>   File "Tools/Scripts/check-webkit-style", line 48, in <module>
>     sys.exit(CheckWebKitStyle().main())
>   File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main
>     patch_checker.check(patch)
>   File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check
>     self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
>   File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
>     self._processor.process(lines, file_path, **kwargs)
>   File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 838, in process
>     checker.check(lines)
>   File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check
>     overrides = self._port_obj.test_expectations_overrides()
> AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides'
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Hi Julien/All,
This is an invalid issue. 
This occurs if style-check is performed on LayoutTests/platform/efl/test_expectations.txt.
i.e., ./Tools/Scripts/check-webkit-style LayoutTests/platform/efl/test_expectations.txt
This issue can be reproduced even on untouched file also.
Its has got nothing to do with my modification on efl test_expectations.
Due this reason, In one of my last patches I added my changes in Skipped file of efl instead of test_expectations. But this time, I created a proper patch based on Julien's review comments to bring to your comments.
Please suggest me how do proceed further.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list