[Webkit-unassigned] [Bug 79441] IPP optimization for functions vsma, vsmul, vadd, vmul and vmaxmgv

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79441





--- Comment #11 from Gao Chun <chun.gao at intel.com>  2012-03-12 05:57:35 PST ---
(From update of attachment 130616)
View in context: https://bugs.webkit.org/attachment.cgi?id=130616&action=review

>> Source/WebCore/platform/audio/VectorMath.cpp:125
>>      if ((sourceStride == 1) && (destStride == 1)) {
> 
> Since both IPP and SSE2 have a restriction on the strides, would it make sense to move the IPP code inside the if so that it is common to both?  Something like
> 
> #if defined(__SSE2__) || USE(WEBAUDIO_IPP)
> if ((sourceStride == 1) && (destStride == 1)) {
> #if USE(WEBAUDIO_IPP)
>    ippsAddProduceC_32f(...)
> #else /* SSE2 */
>    /* original sse2 code */
> #endif
> }
> #endif
> 
> Same comment applies to the rest of the IPP code.

Improved, please review again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.