[Webkit-unassigned] [Bug 77835] [GObject bindings] Missing scope annotations for add/remove_event_listener

Mon Mar 12 02:35:43 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=77835

C Anthony <anthony at xtfx.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131002|0                           |1
        is obsolete|                            |
 Attachment #131002|review?                     |
               Flag|                            |
 Attachment #131302|                            |review?
               Flag|                            |

--- Comment #28 from C Anthony <anthony at xtfx.me>  2012-03-12 02:35:43 PST ---
Created an attachment (id=131302)
 --> (https://bugs.webkit.org/attachment.cgi?id=131302&action=review)
Event Listeners as first class GObjects.

this patch is an improvement on the last, and updated to r110399 (today-ish IIRC)

things changed considerably since my original working tree -- i had to touch many more files just to *allow* the IDL to be processed ... if i could get some feedback ASAP that would be fantastic as im having difficulty keeping up with the changes.

... who else needs to know or should be involved?  i want to be sure my work, or others, are not in conflict.

testcases will be fixed once patch design is approved.
comments will be set to whatever you guys want.

PLEASE see the `handleEvent` except added to CodeGeneratorGObject.pm ... i dont know how to handle this.  i tried using `Supplement`, ie. modifying IDL etc ... not straight forward.  right now both the external and internal impls share the same $interfaceName identifiers, so there is no clean way (AFAICS) for me to operate as a "EventListener" externally (GObject/API), and a GObjectEventlistener internally (WebCore) ...

all in all, i think it's pretty solid, and it does everything as advertised.  will post a little demo app soon.

thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.