[Webkit-unassigned] [Bug 80751] Windows IDL files should use generic pointers for Windows Handles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80751





--- Comment #4 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-11 10:05:45 PST ---
(In reply to comment #3)
> (From update of attachment 131172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131172&action=review
> 
> > Source/WebKit/win/ChangeLog:3
> > +        Windows IDL files should use generic pointers for Windows Handles
> 
> can you explain the why in the changelog
> 
> > Source/WebKit/win/Interfaces/WebKit.idl:61
> > +cpp_quote("#if 0")
> > +typedef long HWND;
> > +typedef long HDC;
> > +typedef long HACCEL;
> > +typedef long HMENU;
> > +typedef long HICON;
> > +typedef long HFONT;
> > +typedef long HRGN;
> > +cpp_quote("#endif")
> 
> can you explain this more detailed (in the ChangeLog)
> Ususally HWND is defined as HANDLE, which is defined as void*. Why can't we do that here?

HANDLE is defined as void*, but that's not a portable type. This change is meaningful for non-C languages such as VB and .Net. The one reference I found using this trick is http://miranda-gds-v2.googlecode.com/svn/trunk/common/GoogleDesktopDisplayAPI.idl. This change shouldn't negatively affect C/C++ but should help other languages.

Is there a way to test whether or not this will break some code in the wild? Does any of our EWS servers consume WebKit COM?

> 
> > Source/WebKit/win/WebKit.vcproj/Interfaces.vcproj:38
> > +				PreprocessorDefinitions="_MIDL_DECLARE_WIREM_HANDLE"
> 
> is there no better place to set the PreporcessorDefinitions in one of the vsprops files?

This should remain local to this project. If there is an appropriate prop file, I'll add it there, otherwise, vcproj is reasonable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.