[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 09:45:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #13 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-11 09:45:23 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > (From update of attachment 131215 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=131215&action=review
> > > 
> > > > Tools/WinLauncher/WinLauncher.cpp:145
> > > > +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView *webView, IWebError *error)
> > > 
> > > why do you still add this change? this and the other patch won't apply as two independed changes (IMHO that's what brent requested)
> > 
> > Because I assume if these two patches are applied after one another, they should contain incremental changes. May be I messed it up while generating the patch, but that was the rationale.
> 
> If the first patch landed the file will contain this line. Then the second patch won't apply, since the line will exist already.

I see that now. Thanks. I'll update the patch with the fixes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list