[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

Sat Mar 10 21:45:33 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=80760

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131180|review?                     |review-
               Flag|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2012-03-10 21:45:33 PST ---
(From update of attachment 131180)
View in context: https://bugs.webkit.org/attachment.cgi?id=131180&action=review

This change includes a lot of white-space modifications. While I agree with these changes, they cause the actual patch to be hard to review due to clutter in the ChangeLog and other areas.

Please generate a patch with the functional change, and a second patch (if you are so inclined), and I'll be happy to approve them separately.

> Tools/WinLauncher/WinLauncher.cpp:150
> +    ::MessageBoxW(0, (LPCWSTR)errorDescription, L"Error", MB_APPLMODAL | MB_OK);

This should be a C++ cast, even though much of the rest of the file still uses C-style casts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.