[Webkit-unassigned] [Bug 80401] [BlackBerry] Credential save and autofill implemetation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 17:06:27 PST 2012


--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2012-03-10 17:06:27 PST ---
(From update of attachment 130343)
View in context: https://bugs.webkit.org/attachment.cgi?id=130343&action=review

I will like we are missing an abstraction layer here :( ... the layering violation and the 'friend' class declaration makes me kinda of sad.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:841
> +            Credential inputCredential = static_cast<FrameLoaderClientBlackBerry*>(m_frame->loader()->client())->authenticationChallenge(newURL, protectionSpace);

That is a layering violation.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list