[Webkit-unassigned] [Bug 79609] LLInt should support JSVALUE64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79609





--- Comment #17 from Filip Pizlo <fpizlo at apple.com>  2012-03-10 12:25:46 PST ---
(In reply to comment #16)
> (From update of attachment 131161 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131161&action=review
> 
> This looks fine to me (other than the unnecessary release mode hash lookups :( ) but i'll let gavin make the final call

This patch does not introduce any unnecessary hash lookups. 

> 
> > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:233
> > +    if (exec->globalData().interpreter->getOpcodeID(pc[0].u.opcode) == op_ret) {
> 
> Doesn't this result in a hash lookup even in release builds without logging?

No. That function only gets called with execution tracing is enabled. It is not enabled by default in any builds.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.