[Webkit-unassigned] [Bug 78358] REGRESSION (Safari 5.0.5 - 5.1): Link is not colored as visited if default port number is present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 06:34:54 PST 2012


--- Comment #7 from webkitlearner at gmail.com  2012-03-10 06:34:53 PST ---
Created an attachment (id=131171)
 --> (https://bugs.webkit.org/attachment.cgi?id=131171&action=review)
It has the modified and original files , if you check the difference between this two files you can get the patch of 78358 bug


When you click on the link 

<a xmlns="http://www.w3.org/1999/xhtml" href="http://www.slowpokeproductions.com:80/wit/%77ittarget1b.xhtml">http, port 80</a>

The KURL object is created for the above link and the url is being parsed and the default port numbers is being removed and the link is loaded and the same link is being stored in the Hashtable.

When you press the back button in the  HTMLAnchorElement.h the following api 

inline LinkHash HTMLAnchorElement::visitedLinkHash() const

is being called which inturn calls WebCore::visitedLinkHash; to which we are passing the base URL and the AtomicString of fastGetAttribute(HTMLNames::hrefAttr). So the url has the default ports and this url is being checked in the hashmap , as it is not stored we are getting the link unvisted and showing blue color.

So we need to send the same type of URL(without ports) for the LinkHash to check for the url visted or not.

So i have the proposed patch where you create the KURL object from the fastGetAttribute(HTMLNames::hrefAttr) and convert it in to AtomicString from the KURL object and send it which solves the issue.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list