[Webkit-unassigned] [Bug 80714] [Qt] [WK2] Shouldn't use item for clipping rect calculation in paint node.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80714


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131115|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-03-09 14:52:03 PST ---
(From update of attachment 131115)
View in context: https://bugs.webkit.org/attachment.cgi?id=131115&action=review

This is good. Let's fix the nitpicks and commit.

> Source/WebKit2/ChangeLog:11
> +        Replace item based clipping rect calculation with clipping nodes based.
> +        Part of threaded rendering implementation.
> +        In Qt5 threaded rendering paint nodes live on paint thread and items on 
> +        main thread. Paint nodes should not have any direct access to items.

Some rewording if you don't mind :)
Replace item based clip-rect calculation with clipping-nodes based calculation.
This is required for threaded rendering, since we don't have access to the QSGItems from the render thread.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:25
> +#include <QPolygonF>

This belongs at the end, before the QtQuick includes.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:126
> +        QRectF resultRect(0, 0, -1, -1);

Comment: start with an invalid rect.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:142
> +                if (geometry->vertexCount() > 2) {

<nitpick>
if (geometry->vertexCount() < 3)
    continue;

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:151
> +            if (!currentClip.isEmpty()) {

if (currentClip.isEmpty())
    continue;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.