[Webkit-unassigned] [Bug 80714] [Qt] [WK2] Shouldn't use item for clipping rect calculation in paint node.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80714





--- Comment #7 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-03-09 14:36:21 PST ---
(From update of attachment 131111)
View in context: https://bugs.webkit.org/attachment.cgi?id=131111&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:159
> +                const QSGGeometry::Point2D* geometryPoints = geometry->vertexDataAsPoint2D();
> +
> +                // Clip region should be at least triangle to make valid clip.
> +                if (geometry->vertexCount() > 2) {
> +                    currentClip.setTopLeft(clipMatrix.map(QPoint(geometryPoints[0].x, geometryPoints[0].y)));
> +
> +                    for (int i = 1; i < geometry->vertexCount(); i++)
> +                        uniteRectWithPoint(currentClip, clipMatrix.map(QPoint(geometryPoints[i].x, geometryPoints[i].y)));
> +                }

Better to add the points to a QPolygonF and then call boundingRect.
Otherwise patch is good.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:162
> +            if (!currentClip.isEmpty()) {

if (currentClip.isEmpty())
    continue;

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:163
> +                if (resultRect.isValid())

Comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.