[Webkit-unassigned] [Bug 80701] getCueAsHTML() should return different fragments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 10:25:21 PST 2012


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
 Attachment #131036|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2012-03-09 10:25:21 PST ---
(From update of attachment 131036)
View in context: https://bugs.webkit.org/attachment.cgi?id=131036&action=review

Nice fix and terrific test - thanks!

> Source/WebCore/html/track/TextTrackCue.cpp:362
> +    RefPtr<DocumentFragment> clonedFragment;
> +    Document* document;

Nit: There is no need to declare these here and initialize them further down in the function. No need to have this block landing the fix, but lets fix it the next time we modify this file.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list