[Webkit-unassigned] [Bug 79601] [EFL] [DRT] Implement scheduleAsynchronousKeyDown.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79601





--- Comment #13 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-03-09 10:12:35 PST ---
(From update of attachment 130807)
View in context: https://bugs.webkit.org/attachment.cgi?id=130807&action=review

Thank you for the review! :)

>> Tools/DumpRenderTree/efl/EventSender.cpp:463
>> +    OwnPtr<KeyEventInfo> keyEventInfo = createKeyEventInfo(context, argumentCount, arguments, exception);
> 
> This will need the adoptPtr(), see bellow.

Done.

>> Tools/DumpRenderTree/efl/EventSender.cpp:464
>> +    sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.release());
> 
> This should be keyEventInfo.get()

Done.

>> Tools/DumpRenderTree/efl/EventSender.cpp:543
>> +    sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.release());
> 
> This should be keyEventInfo.get().

Done.

>> Tools/DumpRenderTree/efl/EventSender.cpp:550
>> +    ecore_idler_add(sendAsynchronousKeyDown, static_cast<void*>(keyEventInfo.leakPtr()));
> 
> Churn =( I think it makes more sense to have createKeyEventInfo return a normal pointer, you're essentially not using this OwnPtr here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.