[Webkit-unassigned] [Bug 80696] Remove custom bindings for attribute type Array.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80696


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131028|                            |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-03-09 09:24:10 PST ---
(From update of attachment 131028)
View in context: https://bugs.webkit.org/attachment.cgi?id=131028&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1774
> +                                push(@implContent, "    const Vector<RefPtr<ScriptProfile> > vector = impl->$implGetterFunctionName();\n\n");

Why ScriptProfile?  Shouldn't it depend on the type?  This doesn't seem right.

Also, is the name "Array" used in the specs?  I thought WebIDL used syntax like DOMString[] that give the type of the array.

> Source/WebCore/page/Console.idl:49
> -        readonly attribute [CustomGetter] Array profiles;
> +        readonly attribute Array profiles;

This change affects JSC and V8 but you've only change the CodeGeneratorJS and not CodeGeneratorV8.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.