[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 09:13:23 PST 2012


--- Comment #9 from Csaba Osztrogonac <ossy at webkit.org>  2012-03-09 09:13:23 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > > Tools/Scripts/webkitpy/style/checkers/png.py:71
> > > > +            self.handle_style_error(0, 'image/png', 5, errorstr)
> > > 
> > > I thought it would look at the diff to determine this. I thought you could set the prop without it being in the config file.
> > 
> > You can if you works with svn, but you can't if you're a git-svn user.
> Interesting.  Does this mean that this check will never catch anything for patches put up here by git users? (As long as the style checker machine is set-up correctly and runs git.)

As far as I know svn:mime-type settings aren't in the patches. But you have 
to setup your svn config correctly on the machine where you commit from.

If you run check-webkit-style before committing it will warn you if your 
svn config is incorrect.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list