[Webkit-unassigned] [Bug 80431] RenderImage ignores its percent width/height when setContainerSizeForRenderer

Fri Mar 9 08:41:26 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=80431

--- Comment #13 from Yong Li <yong.li.webkit at gmail.com>  2012-03-09 08:41:26 PST ---
(In reply to comment #12)
> (From update of attachment 130829 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130829&action=review
> 
> Thanks Yong! Needs another iteration:
> 
> > LayoutTests/svg/as-image/resources/circle-1x1.svg:5
> > +    <circle cx="50%" cy="50%" r="0.3" style="fill:blue;" />
> 
> Please make it green, we don't land non-green circles/rect if not necessary :-)

I copied it from circle.svg. Will change to green rect as I think probably circle is probably not always painted in the same way by different graphics engines.

> 
> > LayoutTests/svg/as-image/svg-as-image-with-relative-size.html:9
> > +    <div width=400px height=300px>
> 
> This doesn't work for <divs>. I've corrected your testcase and included some borders to make it easier to see:
> 
> <html>
> <head>
> <title>svg-as-image-with-relative-size</title>
> <style>
>        body {margin: 0px;}
> </style>
> </head>
> <body>
> <div style="width: 400px; height: 300px; border: 1px solid black;">
> <img width=50% height=50% style="border: 1px solid green;" src='resources/circle-1x1.svg' />
> </body>
> </html>

Thanks!

> 
> Note that your testcase is _perfectly_ suited for a reftest. Please create a svg-as-image-with-reliave-size-expected.html, that contains a standalone <svg> embedded in a <html> modelled to look like the expected image - this will also avoid platform specific results.

Good to know "reftest" :)

> 
> > LayoutTests/svg/as-image/svg-as-image-with-relative-size.html:11
> > +        <!-- The following svg has a width of 1px and a height of 1px and draw a circle inside.
> > +        The circle should still be painted on the page (but the shape is actually oval). -->
> 
> The shape is oval? For me it looks like a regular circle.

Probably because the width/height in div doesn't work

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.