[Webkit-unassigned] [Bug 77712] [JSC] Range of cache flush is not guaranteed by Linux kernel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 03:30:40 PST 2012


--- Comment #3 from Andy Wingo <wingo at igalia.com>  2012-03-09 03:30:39 PST ---
(From update of attachment 130982)
Is size_t the right type to use for startPage and endPage?  It seems safer to use intptr_t or something.

Also it seems to me that you would be better off doing

  uintptr_t start = reinterpret_cast<uintptr_t>(code) & ~(pageSize() - 1);

and just adding pageSize() each round instead of doing the divide-and-multiply dance.  Dunno.

I'm not a reviewer, so please take these comments with a grain of salt.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list