[Webkit-unassigned] [Bug 79875] [BlackBerry] Upstream classes that handle layer tiling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79875





--- Comment #16 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-03-09 00:29:12 PST ---
(In reply to comment #15)
> (From update of attachment 130806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130806&action=review
> 
> Looks good, but needs one more round :)
> 
> > Source/WebCore/platform/graphics/blackberry/LayerTileIndex.h:68
> > +template<> struct IntHash<WebCore::TileIndex> {
> 
> You probably don't need WebCore:: prefixes in this file.
> 
I removed 4 WebCore:: prefixes, the other WebCore:: prefixes in the WTF namespace can not be omitted.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:153
> > +        dirtyRect = IntRect(IntPoint(), requiredTextureSize);
> 
> IntPoint::zero
> 
> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:159
> > +    if (requiredTextureSize.isEmpty() || dirtyRect == IntRect(IntPoint(), requiredTextureSize)) {
> 
> IntPoint::zero
> 
Fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:648
> > +IntSize LayerTiler::defaultTileSize()
> 
> It seems this is only used internally? If so you can make it a free, static function.
> 
Good point, fixed.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.h:104
> > +            : type(type)
> 
> This looks really confusing, can you add m_ to the member vars? This makes it clear which is which.
> 
My bad, I should have found this in the first round. All member variables have been prefixed now.

> > Source/WebCore/platform/graphics/blackberry/LayerTiler.h:122
> > +        static TextureJob setContents(const SkBitmap& contents, bool isOpaque) { return TextureJob(SetContents, contents, IntRect(IntPoint(), IntSize(contents.width(), contents.height())), isOpaque); }
> 
> IntPoint::zero
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.