[Webkit-unassigned] [Bug 79886] ShadowRoot should have activeElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79886


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130803|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-08 23:32:00 PST ---
(From update of attachment 130803)
View in context: https://bugs.webkit.org/attachment.cgi?id=130803&action=review

> Source/WebCore/dom/ShadowRoot.cpp:165
> +Element* ShadowRoot::activeElement() const
> +{
> +    if (document()->isHTMLDocument())
> +        return treeScope()->activeElement();
> +    return 0;
> +}

I think it'll be better to make this function inline so that we don't introduce a new function call in Document::activeElement.

> Source/WebCore/dom/TreeScope.cpp:179
> +    // If treeScope becomes document, document->shadowHost() fails. As toElement(0) throws ASSERT.

I think this comment is more confusing than helpful. Please remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.