[Webkit-unassigned] [Bug 79601] [EFL] [DRT] Implement scheduleAsynchronousKeyDown.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79601





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-03-08 19:04:41 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 130807 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=130807&action=review
> > 
> > > Tools/DumpRenderTree/efl/EventSender.cpp:540
> > > +static Eina_Bool sendAsynchronousKeyDown(void* userData)
> > 
> > We need to use standard boolean instead of Eina_Bool.
> 
> Do you mean we should replace all Eina_Bool to bool that has been used?
> sendClick has also used Eina_Bool in the same file. There are so many places using Eina_Bool, too. I just hope to make a consistence. 
> In my opinion, using Eina_Bool is proper here. Because sendClick & sendAsynchronousKeydown are called by EFL, so we need to meet EFL's interface.
> For such reasons, GTK port also uses its own type, gboolean.

Anyway, let's do not discuss coding style in here anymore. I'm ok for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.