[Webkit-unassigned] [Bug 79601] [EFL] [DRT] Implement scheduleAsynchronousKeyDown.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 17:49:49 PST 2012


--- Comment #7 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-03-08 17:49:49 PST ---
(In reply to comment #6)
> (From update of attachment 130807 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130807&action=review
> > Tools/DumpRenderTree/efl/EventSender.cpp:540
> > +static Eina_Bool sendAsynchronousKeyDown(void* userData)
> We need to use standard boolean instead of Eina_Bool.

Do you mean we should replace all Eina_Bool to bool that has been used?
sendClick has also used Eina_Bool in the same file. There are so many places using Eina_Bool, too. I just hope to make a consistence. 
In my opinion, using Eina_Bool is proper here. Because sendClick & sendAsynchronousKeydown are called by EFL, so we need to meet EFL's interface.
For such reasons, GTK port also uses its own type, gboolean.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list