[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80519





--- Comment #22 from jochen at chromium.org  2012-03-08 07:13:15 PST ---
(In reply to comment #21)
> (In reply to comment #20)
> > The reason that it's behind a #ifdef is that TargetType should not be defined in platform/
> > 
> > If we move the definition to loader/, we can just enable this behavior for all ports. In fact, the more ports start to have out-of-process network stacks, the more will need this feature.
> 
> Thanks for the info! So the solution can be a common ResourceRequestBase (which will have TargetType info) in loader, and every platform still have their own ResourceRequest (which inherits ResourceRequestBase) for their own platform specific stuff?

I think there are two options:

(1) have a class in loader/ that wraps a ResourceRequest (similar to FrameLoadRequest) - however, failing to come up with a good name for such a class, this hasn't happened yet

(2) don't touch ResourceRequest at all, and just define TargetType as a standalone enum and pass it along with the ResourceRequest everywhere an ResourceRequest is passed around in loader/ - I think that's the more likely option right now

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.