[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 8 06:59:09 PST 2012


--- Comment #19 from Lyon Chen <liachen at rim.com>  2012-03-08 06:59:09 PST ---
(In reply to comment #18)
> the embedder should link the target type to the ResourceRequest in willSendRequest
> For chromium, I added ResourceRequest::ExtraData (http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h#L63) to carry arbitrary additional information in an ResourceRequest. 
> In willSendRequest, the TargetType is put into a class deriving from ExtraData and stashed into the ResourceRequest. Now when the ResourceRequest later is passed to our resource loader, it can retrieve the target type from there.

Yeah, the ExtraData class solves the issue of saving TargetType, but still when the TargetType is decided is still an issue, and I feel it is too late to decide in willSendRequest() as it is called after the policy decision stage, at which stage, it seems to me, it is proper to check the TargetType info before deciding the policy for that particular loading.

If the TargetType is still decided in FrameLoader::loadURL(), then whether make it part of ResourceRequest or as an parameter, we still need platform #ifdef.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list