[Webkit-unassigned] [Bug 78872] [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78872


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130677|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #41 from James Robinson <jamesr at chromium.org>  2012-03-07 23:48:23 PST ---
(From update of attachment 130677)
View in context: https://bugs.webkit.org/attachment.cgi?id=130677&action=review

Nice, and clean EWS to boot. R=me, just need to fix up some comments and put this back behind the thread guard to land.

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:90
> +    if (scrollbar->isCustomScrollbar() /* || !CCProxy::hasImplThread() */) { // FIXME: also filter out single thread case when we

think we need to uncomment this check before landing

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:107
> +    if (!scrollLayer) // FIXME: sometimes we get called before setScrollLayer, workaround by finding out ourself

comment isn't quite right - typo in "ourself" and lacks a period at the end (same goes for the one on line 119)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.