[Webkit-unassigned] [Bug 80571] New: Restore color space switching code to run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 22:07:09 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80571

           Summary: Restore color space switching code to run-webkit-tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: timothy_horton at apple.com
                CC: adele at apple.com, mitz at webkit.org,
                    simon.fraser at apple.com,
                    webkit-bug-importer at group.apple.com


Mac/CG pixel results on Lion vary if the display color space is changed.

The attached patch will fix this by returning to our old behavior of setting the systemwide color profile. However, it will address the two concerns from https://bugs.webkit.org/show_bug.cgi?id=72424 by using the new (to us) LayoutTestHelper hooks in run-webkit-tests.

With this patch applied, pixel results from WkTR and DRT match both between each other, and between any chosen system color space.

We should probably find a way to share LayoutTestHelper source with the Chromium port (they're still using deprecated ColorSync API in order to support Leopard), though I'm not sure where to put the code if we do. We'll have to work that out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list