[Webkit-unassigned] [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80519


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130653|review?                     |review-
               Flag|                            |




--- Comment #12 from Adam Barth <abarth at webkit.org>  2012-03-07 17:09:32 PST ---
(From update of attachment 130653)
View in context: https://bugs.webkit.org/attachment.cgi?id=130653&action=review

>> Source/WebCore/loader/FrameLoader.cpp:1223
>> +#if PLATFORM(BLACKBERRY)
>> +    Frame* loadframe = targetFrame ? targetFrame : frame();
>> +    if (loadframe->page()->mainFrame() == loadframe)
>> +        request.setTargetType(ResourceRequest::TargetIsMainFrame);
>> +    else
>> +        request.setTargetType(ResourceRequest::TargetIsSubframe);
>> +#endif
>> +
> 
> Is there any way we can set this somewhere other than FrameLoader, preferably somewhere that doesn't require an #if PLATFORM()? chromium, e.g., does this in its FrameLoaderClientImpl::dispatchWillSendRequest().

We don't want to have PLATFORM-specific ifdefs in FrameLoader.   We have a few of them, but they are mostly sadness.  The Chromium port uses TargetType.  How does it avoid needing this code here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.