[Webkit-unassigned] [Bug 80524] [Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80524


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130665|review?                     |review-
               Flag|                            |




--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2012-03-07 13:38:13 PST ---
(From update of attachment 130665)
View in context: https://bugs.webkit.org/attachment.cgi?id=130665&action=review

One second thought, this seems to make sense. The class is declared in WTFThreadData.h, why not define it in the .cpp. But there's the Chromium build issue :)

> Source/JavaScriptCore/wtf/WTFThreadData.cpp:70
> +namespace JSC {
> +
> +IdentifierTable::~IdentifierTable()
> +{
> +    HashSet<StringImpl*>::iterator end = m_table.end();
> +    for (HashSet<StringImpl*>::iterator iter = m_table.begin(); iter != end; ++iter)
> +        (*iter)->setIsIdentifier(false);
> +}
> +
> +std::pair<HashSet<StringImpl*>::iterator, bool> IdentifierTable::add(StringImpl* value)
> +{
> +    std::pair<HashSet<StringImpl*>::iterator, bool> result = m_table.add(value);
> +    (*result.first)->setIsIdentifier(true);
> +    return result;
>  }

This should be surrounded by #if USE(JSC) to fix the Chromium build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.