[Webkit-unassigned] [Bug 79738] [Qt] Authentication dialog does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79738





--- Comment #14 from Dinu Jacob <dinu.jacob at Nokia.com>  2012-03-07 12:11:32 PST ---
(In reply to comment #12)
> (From update of attachment 130656 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130656&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1385
> > +    if (d->dialogRunner.get())
> > +        event->ignore();
> > +    else {
> > +        forceActiveFocus();
> > +        d->pageView->eventHandler()->handleTouchEvent(event);
> > +    }
> 
> I think webkit style would be an early return, i.e.
> 
>     if (showingDialog)
>         return;
> 
>     forceActiveFocus();
>     d->pageView->eventHandler()->handleTouchEvent(event);

Need to explicitly ignore the event as it is set to accepted (by Qt) when it is received here.

> > Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h:157
> > +    OwnPtr<QtDialogRunner> dialogRunner;
> 
> Do we really need all that ownptr, etc. and all the resulting cosmetic code changes if all we want to know is if we're showing the runner? Why not simply put a boolean in place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.