[Webkit-unassigned] [Bug 79738] [Qt] Authentication dialog does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79738





--- Comment #12 from Simon Hausmann <hausmann at webkit.org>  2012-03-07 12:02:07 PST ---
(From update of attachment 130656)
View in context: https://bugs.webkit.org/attachment.cgi?id=130656&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1385
> +    if (d->dialogRunner.get())
> +        event->ignore();
> +    else {
> +        forceActiveFocus();
> +        d->pageView->eventHandler()->handleTouchEvent(event);
> +    }

I think webkit style would be an early return, i.e.

    if (showingDialog)
        return;

    forceActiveFocus();
    d->pageView->eventHandler()->handleTouchEvent(event);

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h:157
> +    OwnPtr<QtDialogRunner> dialogRunner;

Do we really need all that ownptr, etc. and all the resulting cosmetic code changes if all we want to know is if we're showing the runner? Why not simply put a boolean in place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.