[Webkit-unassigned] [Bug 79738] [Qt] Authentication dialog does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79738





--- Comment #10 from Dinu Jacob <dinu.jacob at Nokia.com>  2012-03-07 10:22:01 PST ---
(In reply to comment #9)
> (From update of attachment 130628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130628&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:285
> > +    dialogRunner = new QtDialogRunner;
> 
> This should use an OwnPtr and you should make a PassOwnPtr QtDialogRunner::create()
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:518
> > +void QQuickWebViewPrivate::destroyDialogRunner()
> > +{
> > +    delete dialogRunner;
> > +    dialogRunner = 0;
> > +}
> 
> ieck! this calls for an OwnPtr

Ah, didn't think about it :( Will change it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.