[Webkit-unassigned] [Bug 80495] [GTK] race condition in run-gtk-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80495


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130627|review?                     |review+
               Flag|                            |




--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2012-03-07 08:42:30 PST ---
(From update of attachment 130627)
View in context: https://bugs.webkit.org/attachment.cgi?id=130627&action=review

Looks good, but consider converting the a11y stuff to use with. Perhaps this could be a follwoup patch.

> Tools/Scripts/run-gtk-tests:149
> +        def run_for_real():

Maybe run_for_real could be called run_tests. :)

> Tools/Scripts/run-gtk-tests:164
> +            if self._a11y_registryd:
> +                self._a11y_registryd.terminate()
> +
> +            a11y_bus_launcher.terminate()

It seems we want to be really sure that the a11y stuff is cleaned up properly when exiting the loop, so I think it makes sense to use "with" here. http://docs.python.org/release/2.5/whatsnew/pep-343.html Without using this, we run the risk of an exception preventing the termination of the a11y stuff. I think I've seen this happen to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.