[Webkit-unassigned] [Bug 79441] IPP optimization for functions vsma, vsmul, vadd, vmul and vmaxmgv

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79441





--- Comment #8 from Gao Chun <chun.gao at intel.com>  2012-03-07 06:56:37 PST ---
(From update of attachment 130336)
View in context: https://bugs.webkit.org/attachment.cgi?id=130336&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests. (OOPS!)
> 
> Can't commit this with "OOPS!".  Do you know if these functions are tested by existing layout tests?  If so, you can just say they are covered by existing tests.

It's already covered by existing layout tests.

>> Source/WebCore/platform/audio/VectorMath.cpp:116
>> +#if USE(WEBAUDIO_IPP)
> 
> Maybe combine line 114 and 116 into #elif USE(WEBAUDIO_IPP)
> 
> Also, I'm not sure which is better.  It's nice to have teh IPP implementations all in one section like the special versions for Darwin, but it might fit better if the bodies of these new routines were added the existing routines so that there would be an SSE2 version, an IPP version, and a default in each function.  But that makes each function harder to read, but it also makes it easier to see if one function needs to be updated to update all the different versions accordingly.

All new routines' bodies have been added to the existing routines, and it looks better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.