[Webkit-unassigned] [Bug 80500] [GTK] remove webkitpy dependency in run-gtk-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 06:42:16 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=80500


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130570|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-03-07 06:42:16 PST ---
(From update of attachment 130570)
View in context: https://bugs.webkit.org/attachment.cgi?id=130570&action=review

Great! Thank you!

> Tools/Scripts/run-gtk-tests:154
> -                out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env,
> -                                                  error_handler=_error_handler)
> +                process = subprocess.Popen([jhbuild_path ,'gtester', test], env=test_env, stdout=subprocess.PIPE)
> +                out = process.communicate()[0]
>                  sys.stdout.write(out)

If you omit the stdout argument altogether, I believe the default is to route it to stdout anyway. Perhaps you can just omit that and sys.stdout.write(out) sys.stdout.flush() altogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list